[ 
https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321490#comment-14321490
 ] 

ASF GitHub Bot commented on WICKET-5837:
----------------------------------------

GitHub user klopfdreh opened a pull request:

    https://github.com/apache/wicket/pull/91

    WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior

    little adjustment for master

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klopfdreh/wicket WICKET-5837-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #91
    
----
commit 5445d7c6171d980a8bc1344005a2709ae748aad0
Author: klopfdreh <klopfdreh@192.168.2.110>
Date:   2015-02-14T15:09:33Z

    WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior

----


> JUnit tests may fail because of AbstractDefaultAjaxBehavior
> -----------------------------------------------------------
>
>                 Key: WICKET-5837
>                 URL: https://issues.apache.org/jira/browse/WICKET-5837
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.0.0-M5, 6.19.0
>            Reporter: Tobias Soloschenko
>            Assignee: Andrea Del Bene
>              Labels: test
>
> Because JSONObject is used in the method 
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component,
>  AjaxRequestAttributes)
> which internally uses a HashMap to store the key value pairs - see 
> org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the 
> attributes rendered in a specific order. This can cause the unit tests to 
> pass in one run and fail in the next run.
> One suggestion would be to switch the HashMap and replace it with at 
> LinkedHashMap to preserve the insertion order.
> See stack trace in comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to