[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346973#comment-14346973
]
Sven Meier commented on WICKET-5847:
------------------------------------
Sorry, but I don't like this:
Under certain circumstances StringResourceModel calls the Localizer and expects
the ${}-expressions to be left untouched, this is broken by this proposal.
We might run into name conflicts too, if properties of the model and other
resources keys are identical.
Furthermore I regard this solution with subclassing as a bad practice:
What if someone wants to add another functionality to localizer, does he have
to subclass once again?
A delegation scheme would be better, but IMHO we need a more general solution
for all resolving inside messages:
Something that incorporates WICKET-5623 with pluggable resolvers, the current
bean resolving being just one of the defaults.
> Support for nested properties keys in translations
> --------------------------------------------------
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 7.0.0-M5
> Reporter: Rob Sonke
> Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
