[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351492#comment-14351492
]
Rob Sonke commented on WICKET-5847:
-----------------------------------
Some things I noticed, in line with Sven's remarks:
- the ${xx} syntax is not a good idea. Code that wraps around the Localizer is
hurt by this approach. Like for example decorators in validators. General
Wicket properties as "This ${input} is required." is breaking. I changed my
custom solution to #{xx} now
- Delegation would definitely be better, although I do not really like that
pattern.
- Pluggable resolvers sounds the best way. Maybe at some higher level as in my
humble opinion it's weird that StringResourceModel's, validators and maybe
other part as well, wrap around Localizer and add extra functionality. But I'm
not aware of the reasons that people chose for this approach. Overall, Wicket
is still really great :)
> Support for nested properties keys in translations
> --------------------------------------------------
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 7.0.0-M5
> Reporter: Rob Sonke
> Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
