[
https://issues.apache.org/jira/browse/WICKET-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380626#comment-15380626
]
ASF GitHub Bot commented on WICKET-6203:
----------------------------------------
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/174#discussion_r71063217
--- Diff: wicket-core/src/main/java/org/apache/wicket/model/IModel.java ---
@@ -113,7 +113,8 @@ default void detach()
}
/**
- * Returns a IModel applying the given mapper to the contained object,
if it is not {@code null}.
+ * Returns a IModel applying the given mapper to the contained object,
if it is not {@code null}
+ * .
--- End diff --
(yell) Please move the dot back on the previous line ! :-)
> rework IModel#mapWith
> ---------------------
>
> Key: WICKET-6203
> URL: https://issues.apache.org/jira/browse/WICKET-6203
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 8.0.0-M1
> Reporter: Matthias Metzger
> Priority: Trivial
> Labels: newbie
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The IModel#mapWith method actually combines two models using a BiFunction.
> Thus another name like 'combineWith' would be much more descriptive of the
> actual task.
> Furthermore providing the BiFunction to combine the two models as the first
> argument of 'mapWith'/'combineWith' might obscure the other Model used for
> longer lambda expressions, since it will be provided after the lambda
> expression. It might be better to provide the other Model as a first argument.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
