Repository: wicket Updated Branches: refs/heads/WICKET-4201-improved-page-provider e1fa342ab -> f3a3aa524
WICKET-4201 renaming PageProvider#isPageInstanceFresh to doesProvideNewPage Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f3a3aa52 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f3a3aa52 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f3a3aa52 Branch: refs/heads/WICKET-4201-improved-page-provider Commit: f3a3aa5240008069a2b5caa67e32d04ec5d8e6ce Parents: e1fa342 Author: Pedro Henrique Oliveira dos Santos <[email protected]> Authored: Sun Feb 5 01:46:48 2017 -0200 Committer: Pedro Henrique Oliveira dos Santos <[email protected]> Committed: Sun Feb 5 01:46:48 2017 -0200 ---------------------------------------------------------------------- .../apache/wicket/core/request/handler/IPageProvider.java | 2 +- .../core/request/handler/ListenerRequestHandler.java | 2 +- .../apache/wicket/core/request/handler/PageProvider.java | 2 +- .../apache/wicket/request/handler/PageProviderTest.java | 10 +++++----- 4 files changed, 8 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/f3a3aa52/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java index 90fdaf8..cb2510a 100644 --- a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java +++ b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java @@ -113,5 +113,5 @@ public interface IPageProvider * @return {@code true} iff the page instance held by this provider was instantiated by the * provider */ - boolean isPageInstanceFresh(); + boolean doesProvideNewPage(); } http://git-wip-us.apache.org/repos/asf/wicket/blob/f3a3aa52/wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerRequestHandler.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerRequestHandler.java b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerRequestHandler.java index f9b3bbc..cc4f7fd 100644 --- a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerRequestHandler.java +++ b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerRequestHandler.java @@ -156,7 +156,7 @@ public class ListenerRequestHandler public void respond(final IRequestCycle requestCycle) { final IRequestablePage page = getPage(); - final boolean freshPage = pageComponentProvider.isPageInstanceFresh(); + final boolean freshPage = pageComponentProvider.doesProvideNewPage(); final boolean isAjax = ((WebRequest)requestCycle.getRequest()).isAjax(); IRequestableComponent component; http://git-wip-us.apache.org/repos/asf/wicket/blob/f3a3aa52/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java index 2934cf3..261502b 100644 --- a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java +++ b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java @@ -236,7 +236,7 @@ public class PageProvider implements IPageProvider, IClusterable * provider */ @Override - public final boolean isPageInstanceFresh() + public final boolean doesProvideNewPage() { if (!this.provision.wasResolved()) { http://git-wip-us.apache.org/repos/asf/wicket/blob/f3a3aa52/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java b/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java index eed70cc..09115a6 100644 --- a/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java +++ b/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java @@ -188,7 +188,7 @@ public class PageProviderTest extends WicketTestCase { PageProvider provider = new PageProvider(new StatelessPageTest()); assertTrue(provider.hasPageInstance()); - assertFalse(provider.isPageInstanceFresh()); + assertFalse(provider.doesProvideNewPage()); } @Test @@ -198,7 +198,7 @@ public class PageProviderTest extends WicketTestCase assertFalse(provider.hasPageInstance()); try { - provider.isPageInstanceFresh(); + provider.doesProvideNewPage(); fail("expected illegal state exception"); } catch (IllegalStateException e) @@ -209,7 +209,7 @@ public class PageProviderTest extends WicketTestCase provider.getPageInstance(); assertTrue(provider.hasPageInstance()); - assertTrue(provider.isPageInstanceFresh()); + assertTrue(provider.doesProvideNewPage()); } @Test @@ -225,7 +225,7 @@ public class PageProviderTest extends WicketTestCase PageProvider provider = mapperContext.new TestPageProvider(page.getPageId(), 0); assertTrue(provider.hasPageInstance()); - assertFalse(provider.isPageInstanceFresh()); + assertFalse(provider.doesProvideNewPage()); } /** @@ -249,7 +249,7 @@ public class PageProviderTest extends WicketTestCase PageProvider provider = new PageProvider(page.getPageId(), MockPageWithLink.class, 0); assertFalse(provider.hasPageInstance()); assertEquals(MockPageWithLink.class, provider.getPageInstance().getClass()); - assertTrue(provider.isPageInstanceFresh()); + assertTrue(provider.doesProvideNewPage()); } /** */
