Repository: wicket Updated Branches: refs/heads/WICKET-4201-improved-page-provider f3a3aa524 -> fe68c817a
WICKET-4201 removing page expired exception from IPageProvider interface, updated javadoc Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/fe68c817 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/fe68c817 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/fe68c817 Branch: refs/heads/WICKET-4201-improved-page-provider Commit: fe68c817a1856cd292a3fcced88de730a48e5ebd Parents: f3a3aa5 Author: Pedro Henrique Oliveira dos Santos <[email protected]> Authored: Sun Feb 5 02:52:34 2017 -0200 Committer: Pedro Henrique Oliveira dos Santos <[email protected]> Committed: Sun Feb 5 02:52:34 2017 -0200 ---------------------------------------------------------------------- .../core/request/handler/IPageProvider.java | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/fe68c817/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java index cb2510a..f0843dc 100644 --- a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java +++ b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java @@ -43,7 +43,7 @@ public interface IPageProvider * could not have been found and the constructor used did not provide enough information * to create new page instance */ - IRequestablePage getPageInstance() throws PageExpiredException; + IRequestablePage getPageInstance(); /** * Returns {@link PageParameters} of the page. @@ -53,11 +53,8 @@ public interface IPageProvider PageParameters getPageParameters(); /** - * Returns whether calling getPageInstance() will result in creating new page instance or - * whether it will be an existing instance (even though it might be pulled from page store). - * - * @return <code>true</code> if calling {@link #getPageInstance()} will create new page - * instance, <code>false</code> otherwise. + * @return negates {@link PageProvider#hasPageInstance()} + * @deprecated use {@link PageProvider#hasPageInstance()} negation instead */ boolean isNewPageInstance(); @@ -95,11 +92,12 @@ public interface IPageProvider void detach(); /** - * Checks whether or not the provider has a page instance. This page instance might have been - * passed to this page provider directly or it may have been instantiated or retrieved from the - * page store. - * - * @return {@code true} iff page instance has been created or retrieved + * If this provider returns existing page, regardless if it was already created by PageProvider + * itself or is or can be found in the data store. The only guarantee is that by calling + * {@link PageProvider#getPageInstance()} this provider will return an existing instance and no + * page will be created. + * + * @return if provides an existing page */ boolean hasPageInstance();
