[ 
https://issues.apache.org/jira/browse/WICKET-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900150#comment-15900150
 ] 

Sven Meier commented on WICKET-6334:
------------------------------------

I don't think the proposed change is adequate:

>With the change ... the checkers will only be used when the root object is an 
>instance of a Page

With NotDetachedModelChecker installed in the CheckingObjectOutputStream, 
devutils' InspectorPage still fails when calculating the size of the page.
WicketObjects#sizeof() is broken, because it detaches the object *after* 
creating the clone with serialization.

IMHO it would be better if WicketObjects#cloneObject() did no checking at all: 
WicketObjects#sizeof() could create a clone, detach it and *then* calculate the 
real size, checking all objects with SerializingObjectSizeOfStrategy.


> WicketObjects#sizeof() should detach Sessions
> ---------------------------------------------
>
>                 Key: WICKET-6334
>                 URL: https://issues.apache.org/jira/browse/WICKET-6334
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 7.6.0
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>            Priority: Minor
>
> Report at users@ : http://markmail.org/message/mq5zs2veaj4q4psg
> Wicket should detach the Session before calculating its size as it does for 
> Component and IDetachable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to