[ 
https://issues.apache.org/jira/browse/WICKET-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900852#comment-15900852
 ] 

Martin Grigorov commented on WICKET-6334:
-----------------------------------------

bq. these won't work either way, since they don't use 
CheckingObjectOutputStream with or without your change.

Ignore the checkers. An application that uses Kryo won't be able to use 
#sizeOf() at all with JavaSerializer.
We can check whether the current serializer is assignable to JavaSerializer and 
if it is then use a new one without checkers. If it is not JavaSerializer then 
just use it.

bq. Me too, but an undetached detachable model with a reference to a 
non-serializable object will fail with JavaSerializer anyway, regardless of any 
objectCheckers.

True! In this case the application will have to call #detach() before calling 
#sizeOf() ...

> WicketObjects#sizeof() should detach Sessions
> ---------------------------------------------
>
>                 Key: WICKET-6334
>                 URL: https://issues.apache.org/jira/browse/WICKET-6334
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 7.6.0
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>            Priority: Minor
>
> Report at users@ : http://markmail.org/message/mq5zs2veaj4q4psg
> Wicket should detach the Session before calculating its size as it does for 
> Component and IDetachable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to