[
https://issues.apache.org/jira/browse/WICKET-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov resolved WICKET-6586.
-------------------------------------
Resolution: Fixed
Fix Version/s: 9.0.0
8.2.0
7.11.0
The suggested PR is merged to 7.x, 8.x and master.
[~skyYaga] Now you can override JavaScriptResourceReference#getResource() to
return a specialization of JavaScriptPackageResource that overrides
#getCompressingEncoding()
> Broken JavaScript due to fix charsetName in JavaScriptPackageResource
> ---------------------------------------------------------------------
>
> Key: WICKET-6586
> URL: https://issues.apache.org/jira/browse/WICKET-6586
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 7.10.0
> Reporter: Andreas Müller
> Assignee: Martin Grigorov
> Priority: Major
> Fix For: 7.11.0, 8.2.0, 9.0.0
>
>
> When running Wicket in DEPLOYMENT Mode, {{DefaultJavaScriptCompressor}} will
> be set as JavaScript Compressor by default to strip Comments and Whitespaces
> from JavaScript files.
> In {{JavaScriptPackageResource}} the {{processResponse}} method sets the
> charsetName fix to "UTF-8", when compressing JS files:
> {code:java}
> @Override
> protected byte[] processResponse(final Attributes attributes, byte[] bytes)
> {
> final byte[] processedResponse = super.processResponse(attributes, bytes);
> IJavaScriptCompressor compressor = getCompressor();
> if (compressor != null && getCompress())
> {
> try
> {
> String charsetName = "UTF-8";
> ...{code}
> If those JavaScript files are not in UTF-8, the Compressor can break those
> files.
> E.g. when using ISO-8859-15 and having umlauts in the file, the umlauts will
> be replaced by the REPLACEMENT CHARACTER "\uefbfbd".
> There should be a way to specify the charsetName in
> {{JavaScriptPackageResource}}.
> E.g. by calling something like
> {{getResourceSettings().setJavaScriptCharset()}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
