[
https://issues.apache.org/jira/browse/WICKET-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652441#comment-16652441
]
Jezza edited comment on WICKET-6558 at 10/16/18 9:09 PM:
---------------------------------------------------------
Are you sure that's the cause?
All pages that the thread locked are unlocked in finally at the end of
#commitRequest.
[Wicket
8.x|https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/page/PageAccessSynchronizer.java#L291]
[Wicket
7.x|https://github.com/apache/wicket/blob/wicket-7.x/wicket-core/src/main/java/org/apache/wicket/page/PageAccessSynchronizer.java#L274]
was (Author: jezza):
Are you sure that's the cause?
All pages that the thread locked are unlocked in finally at the end of
#commitRequest.
[Wicket
8|https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/page/PageAccessSynchronizer.java#L291]
[Wicket
7.X|https://github.com/apache/wicket/blob/wicket-7.x/wicket-core/src/main/java/org/apache/wicket/page/PageAccessSynchronizer.java#L274]
> Prevent package locks after commitRequest
> -----------------------------------------
>
> Key: WICKET-6558
> URL: https://issues.apache.org/jira/browse/WICKET-6558
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 7.10.0
> Reporter: Emond Papegaaij
> Priority: Major
>
> We've had several incidents with page locks not being freed at the end of the
> request. Often the cause of these locks were in our own code, but these
> issues can be hard to debug. I think it should be better if
> `PageAccessSynchronizer` would either refuse the aquire a lock after the
> request has been committed or at least log an error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
