[
https://issues.apache.org/jira/browse/WICKET-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484657#comment-17484657
]
ASF GitHub Bot commented on WICKET-6950:
----------------------------------------
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795652283
##########
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
##########
@@ -245,6 +246,16 @@ public Executor getSendPayloadExecutor()
return sendPayloadExecutor;
}
+ /**
+ * Allows to configure {@link
org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ *
+ * @param webSocketSession The {@link
org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ */
+ public void configureSession(IWebSocketSession webSocketSession)
Review comment:
Yes...you are right. We are somehow "forcing" the settings class to acta
as a listener. Thus we might need to introduce a Listener/Configurer that is
set in Setting and laster on called. This might be more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> wicket web-sockets implementation does not allow to configure/access web
> socket session on onOpen
> -------------------------------------------------------------------------------------------------
>
> Key: WICKET-6950
> URL: https://issues.apache.org/jira/browse/WICKET-6950
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 10.0.0, 9.7.0
> Reporter: Ernesto Reinaldo Barreiro
> Assignee: Ernesto Reinaldo Barreiro
> Priority: Major
> Fix For: 9.8.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
