[
https://issues.apache.org/jira/browse/WICKET-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484668#comment-17484668
]
ASF GitHub Bot commented on WICKET-6950:
----------------------------------------
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795659246
##########
File path:
wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java
##########
@@ -59,11 +65,22 @@ public void init()
getSharedResources().add(ChartWebSocketResource.NAME, new
ChartWebSocketResource());
+ final WebSocketSettings webSocketSettings = new
WebSocketSettings() {
+ @Override
+ public void configureSession(IWebSocketSession
webSocketSession) {
+ LOGGER.info("getMaxIdleTimeout = " +
webSocketSession.getMaxIdleTimeout());
+ // make sessions almost "immortal"
+
webSocketSession.setMaxIdleTimeout(Duration.ofHours(10).toMillis());
Review comment:
@martin-g I saw locally disconnection happening after a few millisecond
of inactivity. Mind connection will be closed once user navigates away from
page. One interesting fact is that specification states that 0 or negative
means for ever, but jetty does not accepts negative values (it throws an
exception) and 0 seems to be really 0. I will double check. What value would
you use here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> wicket web-sockets implementation does not allow to configure/access web
> socket session on onOpen
> -------------------------------------------------------------------------------------------------
>
> Key: WICKET-6950
> URL: https://issues.apache.org/jira/browse/WICKET-6950
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 10.0.0, 9.7.0
> Reporter: Ernesto Reinaldo Barreiro
> Assignee: Ernesto Reinaldo Barreiro
> Priority: Major
> Fix For: 9.8.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
