[ 
https://issues.apache.org/jira/browse/WICKET-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515199#comment-17515199
 ] 

ASF subversion and git services commented on WICKET-6963:
---------------------------------------------------------

Commit 85fab8969a694b46c5b5ea59a37e21f4e0317a00 in wicket's branch 
refs/heads/master from Thomas Heigl
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=85fab89 ]

Revert "WICKET-6963 Use singletons for PanelMarkupSourcingStrategy (#503)"

This reverts commit 2e3e95f919c9eb08eca8898da7d3b3103a497879.


> Use singletons for PanelMarkupSourcingStrategy
> ----------------------------------------------
>
>                 Key: WICKET-6963
>                 URL: https://issues.apache.org/jira/browse/WICKET-6963
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 9.8.0
>            Reporter: Thomas Heigl
>            Assignee: Thomas Heigl
>            Priority: Major
>             Fix For: 10.0.0, 9.9.0
>
>         Attachments: image-2022-03-21-18-21-51-613.png
>
>
> My latest heapdump contained millions of instances of 
> {{{}PanelMarkupSourcingStrategy{}}}:
> !image-2022-03-21-18-21-51-613.png|width=839,height=24!
> This class is completely stateless and only takes a single boolean 
> constructor parameter. We should replace current instances by a factory 
> method and two singletons.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to