[
https://issues.apache.org/jira/browse/WICKET-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515202#comment-17515202
]
Thomas Heigl commented on WICKET-6963:
--------------------------------------
My proposed solution is buggy under some circumstances. See
https://lists.apache.org/thread/y0zthfw2on04sm9wpn60my3x53b8cb3n.
I have reverted the change and will do another take that either removes the
non-final flag {{noMoreWicketHeadTagsAllowed}} or turns it onto a parameter.
> Use singletons for PanelMarkupSourcingStrategy
> ----------------------------------------------
>
> Key: WICKET-6963
> URL: https://issues.apache.org/jira/browse/WICKET-6963
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 9.8.0
> Reporter: Thomas Heigl
> Assignee: Thomas Heigl
> Priority: Major
> Fix For: 10.0.0, 9.9.0
>
> Attachments: image-2022-03-21-18-21-51-613.png
>
>
> My latest heapdump contained millions of instances of
> {{{}PanelMarkupSourcingStrategy{}}}:
> !image-2022-03-21-18-21-51-613.png|width=839,height=24!
> This class is completely stateless and only takes a single boolean
> constructor parameter. We should replace current instances by a factory
> method and two singletons.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
