[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613184#comment-17613184
]
ASF GitHub Bot commented on WICKET-6999:
----------------------------------------
martin-g commented on code in PR #540:
URL: https://github.com/apache/wicket/pull/540#discussion_r985722371
##########
pom.xml:
##########
@@ -891,18 +894,19 @@
<extensions>true</extensions>
<executions>
<execution>
- <id>bundle-manifest</id>
-
<phase>process-classes</phase>
+ <id>default-bundle</id>
+ <phase>package</phase>
<goals>
-
<goal>manifest</goal>
+
<goal>bundle</goal>
</goals>
<configuration>
<instructions>
-
<Export-Package>*</Export-Package>
-
<Import-Package>org.apache.wicket*,
-
org.junit.jupiter*</Import-Package>
-
<DynamicImport-Package>*</DynamicImport-Package>
+
<Require-Capability>osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=11.0))"</Require-Capability>
Review Comment:
This probably should be version 17.0 for `master` and `11` for wicket-9.x
##########
pom.xml:
##########
@@ -891,18 +894,19 @@
<extensions>true</extensions>
<executions>
<execution>
- <id>bundle-manifest</id>
-
<phase>process-classes</phase>
+ <id>default-bundle</id>
+ <phase>package</phase>
<goals>
-
<goal>manifest</goal>
+
<goal>bundle</goal>
</goals>
<configuration>
<instructions>
-
<Export-Package>*</Export-Package>
-
<Import-Package>org.apache.wicket*,
-
org.junit.jupiter*</Import-Package>
-
<DynamicImport-Package>*</DynamicImport-Package>
+
<Require-Capability>osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=11.0))"</Require-Capability>
+
<Export-Package>${osgi.export.package}</Export-Package>
+
<Import-Package>${osgi.import.package}</Import-Package>
+
<DynamicImport-Package>${osgi.dynamicimport.package}</DynamicImport-Package>
<_nouses>true</_nouses>
+ <!
> Missing Export-Package of packages with "internal" in name
> ----------------------------------------------------------
>
> Key: WICKET-6999
> URL: https://issues.apache.org/jira/browse/WICKET-6999
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 8.14.0, 9.11.0
> Reporter: Daniel Stoch
> Priority: Major
> Fix For: 10.0.0, 9.12.0
>
>
> Some packages in Wicket have "internal" word in its name, eg.:
> org.apache.wicket.markup.html.internal
> But they are a part of public API (eg. HtmlHeaderContainer). These packages
> should be exported in MANIFEST.MF file in Export-Package section as in Wicket
> 6.x/7.x.
> I think something was broken in MANIFEST.MF generation, maybe some generator
> plugin (org.apache.felix.maven-bundle-plugin) configuration or version
> change? Packages with "internal" can be by default excluded from
> Export-Package section. But it is not a case in Wicket library.
> Here is excerpt from "Apache Felix Maven Bundle Plugin" documentation:
> {quote}
> <Export-Package> is now assumed to be the set of packages in your local Java
> sources, excluding the default package '.' and any packages containing 'impl'
> or 'internal'. (before version 2 of the bundleplugin it was based on the
> symbolic name)
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
