[ 
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614520#comment-17614520
 ] 

Andrea Del Bene commented on WICKET-6999:
-----------------------------------------

[~mattrpav] [~mgrigorov]  I've backported #540 to wicket-9.x branch. I think 
it's fine but you might take a look at it as further check:

[https://github.com/apache/wicket/commit/227b94027c]

Thank you.

> Missing Export-Package of packages with "internal" in name
> ----------------------------------------------------------
>
>                 Key: WICKET-6999
>                 URL: https://issues.apache.org/jira/browse/WICKET-6999
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 8.14.0, 9.11.0
>            Reporter: Daniel Stoch
>            Priority: Major
>             Fix For: 10.0.0, 9.12.0
>
>
> Some packages in Wicket have "internal" word in its name, eg.:
> org.apache.wicket.markup.html.internal
> But they are a part of public API (eg. HtmlHeaderContainer). These packages 
> should be exported in MANIFEST.MF file in Export-Package section as in Wicket 
> 6.x/7.x.
> I think something was broken in MANIFEST.MF generation, maybe some generator 
> plugin (org.apache.felix.maven-bundle-plugin) configuration or version 
> change? Packages with "internal" can be by default excluded from 
> Export-Package section. But it is not a case in Wicket library.
> Here is excerpt from "Apache Felix Maven Bundle Plugin" documentation:
> {quote}
> <Export-Package> is now assumed to be the set of packages in your local Java 
> sources, excluding the default package '.' and any packages containing 'impl' 
> or 'internal'. (before version 2 of the bundleplugin it was based on the 
> symbolic name)
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to