Taher-Ghaleb commented on code in PR #601:
URL: https://github.com/apache/wicket/pull/601#discussion_r1303755243
##########
wicket-core/src/test/java/org/apache/wicket/markup/MarkupParserTest.java:
##########
@@ -67,31 +67,31 @@ void tagParsing() throws Exception
final ComponentTag aOpen = (ComponentTag)markupStream.next();
log.info("", aOpen);
- assertTrue(aOpen.getName().equals("a"));
+ assertEquals(aOpen.getName(), "a");
Review Comment:
What is your opinion about this refactoring, please? Why do you think there
are many cases like `assertTrue(x.equals(y))` and `assertFalse(x.equals(y))` or
`assertTrue(!x.equals(y))`, though `assertEquals` and `assertNotEquals` are
more readable/intuitive and can provide better error messages in case of
failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
