solomax commented on code in PR #601:
URL: https://github.com/apache/wicket/pull/601#discussion_r1303767762
##########
wicket-core/src/test/java/org/apache/wicket/markup/MarkupParserTest.java:
##########
@@ -67,31 +67,31 @@ void tagParsing() throws Exception
final ComponentTag aOpen = (ComponentTag)markupStream.next();
log.info("", aOpen);
- assertTrue(aOpen.getName().equals("a"));
+ assertEquals(aOpen.getName(), "a");
assertEquals("foo.html",
aOpen.getAttributes().getString("href"));
markupStream.next();
final ComponentTag boldOpen = (ComponentTag)markupStream.next();
log.info("", boldOpen);
- assertTrue(boldOpen.getName().equals("b"));
+ assertEquals(boldOpen.getName(), "b");
Review Comment:
Please do another change:
`assertEquals` defined as follows: `assertEquals(expected, actual)` so these
2 arguments need to be swapped
Please ensure the order is correct for all asserts you have changed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
