martin-g commented on code in PR #1041:
URL: https://github.com/apache/wicket/pull/1041#discussion_r1851961245
##########
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js:
##########
@@ -183,6 +184,12 @@
hideAutoComplete();
+ if
(cfg.focusInputOnTabSelection && keyCode === KEY_TAB) {
Review Comment:
If you like my idea of using an enum, then here the code would look like:
```suggestion
if
(cfg.focusInputOnTabSelection == "some_enum_value" && keyCode === KEY_TAB) {
```
##########
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js:
##########
@@ -183,6 +184,12 @@
hideAutoComplete();
+ if
(cfg.focusInputOnTabSelection && keyCode === KEY_TAB) {
Review Comment:
If you like my idea of using an enum, then here the code would look like:
```suggestion
if
(cfg.focusInputOnTabSelection === "some_enum_value" && keyCode === KEY_TAB) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
