martin-g commented on code in PR #1041:
URL: https://github.com/apache/wicket/pull/1041#discussion_r1851960217


##########
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java:
##########
@@ -379,4 +381,30 @@ public AutoCompleteSettings setMinInputLength(int 
minInputLength)
                this.minInputLength = minInputLength;
                return this;
        }
+
+       /**
+        * Indicates how the Tab key should be handled when having an item in 
the autocomplete list
+        * selected.
+        *
+        * @return <code>true</code> if the focus should return to the input 
field, <code>false</code>
+        * moves the focus to the next component.
+        */
+       public boolean shouldFocusInputOnTabSelection()

Review Comment:
   IMO it would be better to use an enum here instead of boolean.
   This way it would be:
   1) more clear what the values mean
   2) easier to add more values/states later
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to