[ 
https://issues.apache.org/jira/browse/WICKET-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900439#comment-17900439
 ] 

ASF subversion and git services commented on WICKET-3899:
---------------------------------------------------------

Commit b3a7d62f8c11237dc3a76e6561e2ea6ce2ad3ecb in wicket's branch 
refs/heads/master from Pedro Henrique Oliveira dos Santos
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=b3a7d62f8c ]

WICKET-3899 nested form processing test

 - removing traversal signaling dead code
 - fix form validator when dependent components aren't enabled or
 form participants
 - internalMarkFormComponentsValid in postorder
 - updateNestedFormComponentModels in postorder
 - internalOnValidateModelObjects in porstorder


> IFormVisitorParticipant don't get tested when validating form validators 
> dependent components
> ---------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3899
>                 URL: https://issues.apache.org/jira/browse/WICKET-3899
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.17, 1.5-RC5.1
>            Reporter: Pedro Santos
>            Assignee: Pedro Santos
>            Priority: Major
>         Attachments: WICKET-3899-fix-test.patch, WICKET-3899.patch
>
>
> Currently Form#validateFormValidator only check if dependent components are 
> visible in the page, which causes it to validate forms depending on 
> components that didn't participate in the form processing like:
>  * disable form components
>  * components under an IFormVisitorParticipant parent that returned false in 
> the #processChildren test
>  * components inside a form that was not processed due the 
> Form#wantSubmitOnParentFormSubmit test inside a parent form



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to