[
https://issues.apache.org/jira/browse/WICKET-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922019#comment-17922019
]
Johannes Renoth commented on WICKET-3899:
-----------------------------------------
Some of our Tests fail after this change:
See my comment:
[https://github.com/apache/wicket/pull/1033#discussion_r1933430804]
!image-2025-01-29-09-26-47-144.png!
The form is submitted even though the submitter is disabled and not visible in
hierarchy. This comes from a Tester.submitForm call. I dont know if this also
affects non-test environments, but i thought you should know.
{code:java}
process:977, Form (org.apache.wicket.markup.html.form)
onFormSubmitted:842, Form (org.apache.wicket.markup.html.form)
onRequest:743, Form (org.apache.wicket.markup.html.form)
internalInvoke:300, ListenerRequestHandler
(org.apache.wicket.core.request.handler)
invoke:249, ListenerRequestHandler (org.apache.wicket.core.request.handler)
invokeListener:209, ListenerRequestHandler
(org.apache.wicket.core.request.handler)
respond:202, ListenerRequestHandler (org.apache.wicket.core.request.handler)
respond:913, RequestCycle$HandlerExecutor (org.apache.wicket.request.cycle)
execute:63, RequestHandlerExecutor (org.apache.wicket.request)
execute:294, RequestCycle (org.apache.wicket.request.cycle)
processRequest:255, RequestCycle (org.apache.wicket.request.cycle)
processRequestAndDetach:223, RequestCycle (org.apache.wicket.request.cycle)
processRequest:719, BaseWicketTester (org.apache.wicket.util.tester)
processRequest:658, BaseWicketTester (org.apache.wicket.util.tester)
processRequest:630, BaseWicketTester (org.apache.wicket.util.tester)
submitForm:2087, BaseWicketTester (org.apache.wicket.util.tester)
submit:690, FormTester (org.apache.wicket.util.tester)
submit:770, FormTester (org.apache.wicket.util.tester)
submit:734, FormTester (org.apache.wicket.util.tester) {code}
> IFormVisitorParticipant don't get tested when validating form validators
> dependent components
> ---------------------------------------------------------------------------------------------
>
> Key: WICKET-3899
> URL: https://issues.apache.org/jira/browse/WICKET-3899
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.17, 1.5-RC5.1
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Priority: Major
> Fix For: 10.3.0
>
> Attachments: WICKET-3899-fix-test.patch, WICKET-3899.patch,
> image-2025-01-29-09-26-47-144.png
>
>
> Currently Form#validateFormValidator only check if dependent components are
> visible in the page, which causes it to validate forms depending on
> components that didn't participate in the form processing like:
> * disable form components
> * components under an IFormVisitorParticipant parent that returned false in
> the #processChildren test
> * components inside a form that was not processed due the
> Form#wantSubmitOnParentFormSubmit test inside a parent form
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
