renoth commented on code in PR #1033:
URL: https://github.com/apache/wicket/pull/1033#discussion_r1933430804
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -757,7 +741,7 @@ public final boolean isSubmitted()
@Override
public final void onRequest()
{
- onFormSubmitted(null);
+ onFormSubmitted(findSubmitter());
Review Comment:
@martin-g This seems a bit problematic. We have failing Tests after
upgrading from 10.2. to 10.4 and the reason seems to be that while the
submitter is calculated the same as before, there is no check for visibility
anymore (like in Line 810ff) and the code does run straight to Line 839 instead
of Line 810 because the submitter is not null anymore when checking in line 801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
