mira-silhavy commented on code in PR #1033:
URL: https://github.com/apache/wicket/pull/1033#discussion_r2106799201
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -2059,13 +2020,13 @@ protected final void validateFormValidator(final
IFormValidator validator)
}
// check if the dependent component is visible
and is attached to
// the page
- else if
(!isFormComponentVisibleInPage(dependent))
+ else if (!dependent.isVisibleInHierarchy() ||
!dependent.isEnabledInHierarchy() || !dependent.isFormParticipant())
Review Comment:
Was this causing problems any problems and what do you mean by "dirty" data?
If component is disabled it's still visible on page, but it's not editable
so I wouldn't call it that is has "dirty" data if that's what you mean. In our
use case the component can be enabled/disabled in certain scenarios, but we
still read the its value during validation. Now I'll need to exclude it from
`FormValidator` dependent components to make sure the validation actually takes
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
