mattrpav commented on code in PR #1093:
URL: https://github.com/apache/wicket/pull/1093#discussion_r1937528474
##########
wicket-core/src/main/java/org/apache/wicket/application/CompoundClassResolver.java:
##########
@@ -153,4 +155,4 @@ public CompoundClassResolver remove(final IClassResolver
resolver)
resolvers.remove(resolver);
return this;
}
-}
\ No newline at end of file
+}
Review Comment:
Code style EOF new line?
##########
wicket-core-tests/src/test/java/org/apache/wicket/core/request/mapper/BasicResourceReferenceMapperTest.java:
##########
@@ -47,6 +45,10 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
Review Comment:
static imports usually come before non-static?
##########
wicket-core/src/main/java/org/apache/wicket/ajax/attributes/ThrottlingSettings.java:
##########
@@ -131,4 +133,4 @@ public void setPostponeTimerOnUpdate(boolean
postponeTimerOnUpdate)
this.postponeTimerOnUpdate = postponeTimerOnUpdate;
}
-}
\ No newline at end of file
+}
Review Comment:
Does the Wicket code style call for newline or no newline at end of file?
##########
wicket-core/src/main/java/org/apache/wicket/application/IClassResolver.java:
##########
@@ -45,12 +47,12 @@ public interface IClassResolver
* @param name
* @return iterator over matching resources
*/
- Iterator<URL> getResources(String name);
+ Iterator<URL> getResources(@Nonnull String name);
/**
* Returns the {@link ClassLoader} to be used for resolving classes
*
* @return the {@link ClassLoader} to be used for resolving classes
*/
ClassLoader getClassLoader();
-}
\ No newline at end of file
+}
Review Comment:
Code style EOF new line?
##########
wicket-core/src/main/java/org/apache/wicket/core/util/crypt/AESCrypt.java:
##########
@@ -129,4 +131,4 @@ protected byte[] encrypt(byte[] plainBytes)
}
}
-}
\ No newline at end of file
+}
Review Comment:
Code style EOF new line?
##########
wicket-guice/src/test/java/org/apache/wicket/guice/JakartaInjectTestBehavior.java:
##########
@@ -16,13 +16,14 @@
*/
package org.apache.wicket.guice;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
import jakarta.inject.Inject;
import org.apache.wicket.Component;
import org.apache.wicket.behavior.Behavior;
+import javax.annotation.Nonnull;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
Review Comment:
static imports first?
##########
wicket-native-websocket/wicket-native-websocket-core/pom.xml:
##########
@@ -34,6 +34,10 @@
<osgi.import.package>!java*,!kotlin*,!sun.nio.ch,org.slf4j*;version="[1.7,3)",*</osgi.import.package>
</properties>
<dependencies>
+ <dependency>
+ <groupId>jakarta.annotation</groupId>
+ <artifactId>jakarta.annotation-api</artifactId>
+ </dependency>
<dependency>
Review Comment:
Good time to fix the wicket-native-websocket-core/pom.xml formatting?
##########
wicket-core/src/main/java/org/apache/wicket/markup/repeater/data/GridView.java:
##########
@@ -335,4 +337,4 @@ private void findNext()
}
}
-}
\ No newline at end of file
+}
Review Comment:
Code style EOF new line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
