jstuyts commented on PR #1093: URL: https://github.com/apache/wicket/pull/1093#issuecomment-2631124684
> I'm about 1/2 through the review a couple of comments: Thanks, I'll fix everything once you're done. > 1. If there are null check fixes, it would be good if they were in a separate commit so those changes could potentially be back-ported. There is only 1 in production code: `OriginResourceIsolationPolicy` (search for `Checks.notNull`). The other 2 are in test code: `BaseWicketTester` and `WicketTesterTest` (search for `assertNull`). If you want, I can create a separate issue and PRs for backporting those. > 2. Please see the code style notes around import static and end-of-file new lines. I'll check the notes and will make sure all changed files comply with them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
