jstuyts commented on PR #1093: URL: https://github.com/apache/wicket/pull/1093#issuecomment-2634017788
> JSpecify is perfectly usable already but it has a couple of non-intuitive annotation usages. Your example is one of them. See https://jspecify.dev/docs/user-guide/#some-subtler-details. Got it. I have created a branch using JSpecify: https://github.com/jstuyts/wicket/tree/add-non-null-to-parameters-jspecify The advantages are: * It seems like the Java ecosystem is moving to JSpecify as the semantics are more precise and there is more tooling support. * The Kotlin compiler understands the annotations of JSpecify. Let me know if you decide you would like to use JSpecify instead of the Jakarta annotations. I will close this PR and create a new one. Another remark about which annotations to use. I think the annotations should be added incrementally, and both annotations (nullable and not nullable) must be added. Once everything is annotated (which can take quite some time), the decision to switch to package-level (or some other level) annotations can be made. It is then also easy to determine which of the 2 annotations results in the least amount of code. The most occurring annotation can be changed to higher-level annotations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
