[
https://issues.apache.org/jira/browse/WICKET-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030547#comment-18030547
]
Sebastian Gooren commented on WICKET-7166:
------------------------------------------
[~solomax] found the following difference between master and wicket-9.x:
I was able to reproduce this one
After comparing pom files with master branch I was able to fix the
issue with the following patch:
{noformat}
===================================================================
diff --git a/pom.xml b/pom.xml
index 730d253455..858ee82091 100644
--- a/pom.xml
+++ b/pom.xml
@@ -885,9 +885,9 @@
<executions>
<execution>
<id>default-bundle</id>
- <phase>package</phase>
+
<phase>process-classes</phase>
<goals>
-
<goal>bundle</goal>
+
<goal>manifest</goal>
</goals>
<configuration>
<instructions>
diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml
index f889a95ccb..e7f4b07366 100644
--- a/wicket-core/pom.xml
+++ b/wicket-core/pom.xml
@@ -24,7 +24,7 @@
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-core</artifactId>
- <packaging>bundle</packaging>
+ <packaging>jar</packaging>
<name>Wicket Core</name>
<description>
Wicket is a Java web application framework that takes
simplicity,
==================================================================={noformat}
I'm not an expert in bundle-plugin so not sure if above changes are correct
> Minified wicket-ajax-jquery.js is not in wicket-core maven artifact
> -------------------------------------------------------------------
>
> Key: WICKET-7166
> URL: https://issues.apache.org/jira/browse/WICKET-7166
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 9.21.0
> Reporter: Sebastian Gooren
> Priority: Minor
>
> For one of our projects we have been optimizing all of our resources (css,
> js).
>
> However, some of our tools complain that the wicket js files are not minified.
> So I checked and see that this is true.
>
> In production we see that the standard wicket javascript compressor is used,
> which does not do much (it pretty much looks like tabs and some newlines are
> stripped). So the non-minified js is loaded and “compressed” once in after
> startup.
>
> The maven plugin resources-optimizer-maven-plugin is loaded for this in the
> pom.xml, but it seems that it is not outputting anything.
>
> When I browse the wicket-core maven artifact we use (9.21.0), I only see the
> original wicket-ajax-jquery.js in it, no wicket-ajax-jquery.min.js;
> So it looks like the maven plugin is not minifying the framework js.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
