[ 
https://issues.apache.org/jira/browse/WICKET-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030552#comment-18030552
 ] 

Sebastian Gooren commented on WICKET-7166:
------------------------------------------

The change Maxim found to fix this is a change that was made in master here:

[https://github.com/apache/wicket/commit/7652239b31c6b3fccaf62d39069f35fe0df6cec3]

with reference to https://issues.apache.org/jira/browse/WICKET-7090

It appears at the time of that fix nobody was aware that 
wicket-ajax-jquery.min.js was not in the wicket-core artifact.

E.g. I had a look at the 10.0.0-M2 artifact and it also does not contain the 
minified js file 
([https://repo1.maven.org/maven2/org/apache/wicket/wicket-core/10.0.0-M2/wicket-core-10.0.0-M2.jar).|https://repo1.maven.org/maven2/org/apache/wicket/wicket-core/10.0.0-M2/wicket-core-10.0.0-M2.jar]

The 10.0.0 release *does* contain the minified js file 
([https://repo1.maven.org/maven2/org/apache/wicket/wicket-core/10.0.0/wicket-core-10.0.0.jar]).

> Minified wicket-ajax-jquery.js is not in wicket-core maven artifact
> -------------------------------------------------------------------
>
>                 Key: WICKET-7166
>                 URL: https://issues.apache.org/jira/browse/WICKET-7166
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 9.21.0
>            Reporter: Sebastian Gooren
>            Priority: Minor
>
> For one of our projects we have been optimizing all of our resources (css, 
> js).
>  
> However, some of our tools complain that the wicket js files are not minified.
> So I checked and see that this is true.
>  
> In production we see that the standard wicket javascript compressor is used, 
> which does not do much (it pretty much looks like tabs and some newlines are 
> stripped). So the non-minified js is loaded and “compressed” once in after 
> startup.
>  
> The maven plugin resources-optimizer-maven-plugin is loaded for this in the 
> pom.xml, but it seems that it is not outputting anything.
>  
> When I browse the wicket-core maven artifact we use (9.21.0), I only see the 
> original wicket-ajax-jquery.js in it, no wicket-ajax-jquery.min.js;
> So it looks like the maven plugin is not minifying the framework js.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to