[
https://issues.apache.org/jira/browse/WICKET-7170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040828#comment-18040828
]
ASF GitHub Bot commented on WICKET-7170:
----------------------------------------
martin-g commented on PR #1310:
URL: https://github.com/apache/wicket/pull/1310#issuecomment-3581467519
Well, my experience is the opposite: restructuring and bugfix/feature impl
should not be mixed in the same Pull Request! Even worse in the same commit!
This way the bugfix/feature is hidden in a lot of noise (the restructuring).
It is not clear whether the bugfix/feature does not break some previous
behavior because now the old tests are reworked too. Even though the intention
was to improve them there is a chance that they were actually broken.
I am grateful for your contribution but I won't review it in its current
state.
Hopefully someone else from the team will do it.
> SpringInjector / AnnotProxyFieldValueFactory does not consider
> defaultCandidate
> -------------------------------------------------------------------------------
>
> Key: WICKET-7170
> URL: https://issues.apache.org/jira/browse/WICKET-7170
> Project: Wicket
> Issue Type: Bug
> Components: wicket-spring
> Affects Versions: 10.7.0
> Reporter: Hans Schäfer
> Priority: Major
>
> Spring considers the defaultCandidate-Flag, supplementary to the
> autowireCandidate-Flag. This ist currently not supported by SpringInjector /
> AnnotProxyFieldValueFactory.
> Assume 2 Beans of the same Class / Type: one is autowiredCandidate=true /
> defaultCandidate=true, the second is autowireCandidate=true but
> defaultCandidate = false.
> Spring always chosses the first one for autowiring, if no explicit beanName
> is given.
> Wicket complains about 2 beans of same type.
> Spring had a similar issue when creating proxies for beans with
> defaultCandidate = false:
> [https://github.com/spring-projects/spring-framework/issues/35626]
> There is a Pull Request that fixes this issue:
> [https://github.com/apache/wicket/pull/1310]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
