[
https://issues.apache.org/jira/browse/WICKET-7170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040856#comment-18040856
]
ASF GitHub Bot commented on WICKET-7170:
----------------------------------------
hosea commented on code in PR #1311:
URL: https://github.com/apache/wicket/pull/1311#discussion_r2565541903
##########
wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java:
##########
@@ -230,14 +232,14 @@ private String getBeanNameOfClass(final
ApplicationContext ctx, final Class<?> c
Arrays.asList(BeanFactoryUtils.beanNamesForTypeIncludingAncestors(ctx,
resolvableType)));
// filter out beans that are not candidates for autowiring
- if (ctx instanceof AbstractApplicationContext)
+ if (ctx instanceof AbstractApplicationContext
abstractApplicationContext)
{
- Iterator<String> it = names.iterator();
+ final Iterator<String> it = names.iterator();
while (it.hasNext())
{
final String possibility = it.next();
- BeanDefinition beanDef = getBeanDefinition(
-
((AbstractApplicationContext)ctx).getBeanFactory(), possibility);
+ final ConfigurableListableBeanFactory
beanFactory = abstractApplicationContext.getBeanFactory();
+ final BeanDefinition beanDef =
getBeanDefinition(beanFactory, possibility);
Review Comment:
Replaced Cast with variable defined in instanceof above
> SpringInjector / AnnotProxyFieldValueFactory does not consider
> defaultCandidate
> -------------------------------------------------------------------------------
>
> Key: WICKET-7170
> URL: https://issues.apache.org/jira/browse/WICKET-7170
> Project: Wicket
> Issue Type: Bug
> Components: wicket-spring
> Affects Versions: 10.7.0
> Reporter: Hans Schäfer
> Priority: Major
>
> Spring considers the defaultCandidate-Flag, supplementary to the
> autowireCandidate-Flag. This ist currently not supported by SpringInjector /
> AnnotProxyFieldValueFactory.
> Assume 2 Beans of the same Class / Type: one is autowiredCandidate=true /
> defaultCandidate=true, the second is autowireCandidate=true but
> defaultCandidate = false.
> Spring always chosses the first one for autowiring, if no explicit beanName
> is given.
> Wicket complains about 2 beans of same type.
> Spring had a similar issue when creating proxies for beans with
> defaultCandidate = false:
> [https://github.com/spring-projects/spring-framework/issues/35626]
> There is a Pull Request that fixes this issue:
> [https://github.com/apache/wicket/pull/1310]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
