[
https://issues.apache.org/jira/browse/WICKET-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058691#comment-18058691
]
ASF GitHub Bot commented on WICKET-7126:
----------------------------------------
pedrosans opened a new pull request, #1369:
URL: https://github.com/apache/wicket/pull/1369
This change clean up CdiConfiguration and BeanManagerLookup by removing some
logic and state related to fallbackBeanManager and lastSuccessful strategy,
while removing none of the functionality. For instance, it's still possible to
have a fallback BeanManager as a config option if the current lookup fail:
bm = BeanManagerLookup.lookup();
if (bm == null)
bm = customBeamManager;
Another benefit of this change is the reduced number of times the new code
will make expensive (time consuming) JNDI lookups.
> CdiConfiguration new API
> ------------------------
>
> Key: WICKET-7126
> URL: https://issues.apache.org/jira/browse/WICKET-7126
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-cdi
> Reporter: Pedro Henrique Oliveira dos Santos
> Assignee: Pedro Santos
> Priority: Minor
>
> Context: originally BeanManagerLookup contained the entire logic to resolve
> the app BeanManager, with no option to set one manually, for instance. This
> was improved last year, but the code became a mix of states being kept in
> CdiConfiguration and BeanManagerLookup.
> Improvement:
> * move the entire logic + state to CdiConfiguration
> ** to remove the CdiConfiguration.set/getFallbackBeanManager and its related
> logic
> ** to remove the BeanManagerLookup lastSuccessful state
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
