[
https://issues.apache.org/jira/browse/WICKET-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058763#comment-18058763
]
ASF GitHub Bot commented on WICKET-7126:
----------------------------------------
pedrosans commented on PR #1369:
URL: https://github.com/apache/wicket/pull/1369#issuecomment-3905068110
build fails with:
`Error: Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.25.4:cmp (default) on project
wicket-cdi: There is at least one incompatibility:
org.apache.wicket.cdi.CdiConfiguration.getFallbackBeanManager():METHOD_REMOVED,org.apache.wicket.cdi.CdiConfiguration.setFallbackBeanManager(jakarta.enterprise.inject.spi.BeanManager):METHOD_REMOVED
-> [Help 1]`
but the current version (11.0.0-SNAPSHOT) has no previous 11.0.x one to be
incompatible. Let me know if it's the case to better setup the japicmp tool or
to ignore (if possible) the fail.
> CdiConfiguration new API
> ------------------------
>
> Key: WICKET-7126
> URL: https://issues.apache.org/jira/browse/WICKET-7126
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-cdi
> Reporter: Pedro Henrique Oliveira dos Santos
> Assignee: Pedro Santos
> Priority: Minor
>
> Context: originally BeanManagerLookup contained the entire logic to resolve
> the app BeanManager, with no option to set one manually, for instance. This
> was improved last year, but the code became a mix of states being kept in
> CdiConfiguration and BeanManagerLookup.
> Improvement:
> * move the entire logic + state to CdiConfiguration
> ** to remove the CdiConfiguration.set/getFallbackBeanManager and its related
> logic
> ** to remove the BeanManagerLookup lastSuccessful state
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
