[
https://issues.apache.org/jira/browse/WICKET-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18112926#comment-18112926
]
ASF GitHub Bot commented on WICKET-7204:
----------------------------------------
reiern70 commented on code in PR #1577:
URL: https://github.com/apache/wicket/pull/1577#discussion_r3960181638
##########
wicket-ioc/src/main/java/org/apache/wicket/proxy/bytebuddy/ByteBuddyProxyFactory.java:
##########
@@ -116,10 +120,26 @@ public static <T> Class<T> createOrGetProxyClass(Class<T>
type)
.implement(InterceptorMutator.class).intercept(FieldAccessor.ofBeanProperty())
.implement(Serializable.class,
IWriteReplace.class,
ILazyInitProxy.class).intercept(MethodDelegation.toField(INTERCEPTOR_FIELD_NAME))
.make()
- .load(classLoader,
ClassLoadingStrategy.Default.INJECTION.allowExistingTypes())
+ .load(classLoader,
loadingStrategy)
.getLoaded());
}
+ private static ClassLoadingStrategy<ClassLoader>
resolveLoadingStrategy(Class<?> type)
Review Comment:
@bitstorm javadoc?
> Don't use INJECTION for ByteBuddy proxy creation
> -------------------------------------------------
>
> Key: WICKET-7204
> URL: https://issues.apache.org/jira/browse/WICKET-7204
> Project: Wicket
> Issue Type: Improvement
> Reporter: Andrea Del Bene
> Assignee: Andrea Del Bene
> Priority: Major
> Fix For: 11.0.0
>
>
> The current proxy creation with byte buddy uses
> ClassLoadingStrategy.Default.INJECTION. ad class loading strategy, but this
> relies on Java Unsafe support, which is deprecated and disabled with the
> newer release of ByteBuddy
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
