[ 
https://issues.apache.org/jira/browse/WICKET-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18112979#comment-18112979
 ] 

ASF GitHub Bot commented on WICKET-7204:
----------------------------------------

bitstorm commented on code in PR #1577:
URL: https://github.com/apache/wicket/pull/1577#discussion_r3961754690


##########
pom.xml:
##########
@@ -159,7 +159,7 @@
                <aspectj.version>1.9.25.1</aspectj.version>
                <assertj-core.version>3.27.7</assertj-core.version>
                <bouncycastle.version>1.85.2</bouncycastle.version>
-               <byte-buddy.version>1.18.8</byte-buddy.version>
+               <byte-buddy.version>1.18.13</byte-buddy.version>

Review Comment:
   It fails on JDK > 25 (i.e. 26) starting from version 1.18.9. See PR 
https://github.com/apache/wicket/pull/1574 . So yes, we better keep version 
bumping out of this commit but I had to do it to test the result on JDK 26.





> Don't use INJECTION for ByteBuddy proxy creation 
> -------------------------------------------------
>
>                 Key: WICKET-7204
>                 URL: https://issues.apache.org/jira/browse/WICKET-7204
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Andrea Del Bene
>            Assignee: Andrea Del Bene
>            Priority: Major
>             Fix For: 11.0.0
>
>
> The current proxy creation with byte buddy uses 
> ClassLoadingStrategy.Default.INJECTION. ad class loading strategy, but this 
> relies on Java Unsafe support, which is deprecated and disabled with the 
> newer release of ByteBuddy



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to