papegaaij opened a new pull request, #1733:
URL: https://github.com/apache/wicket/pull/1733
Part of #1723. **Merge after #1732**, which adds the RAT check that replaces
these tests.
Every module carried an `ApacheLicenceHeaderTest` built on
`ApacheLicenseHeaderTestCase`, each with its own ignore lists. With RAT
checking the whole tree, they check a subset of the same thing a second time,
and their ignore lists would have to be kept in step with `.rat-excludes`.
## What changes
- **The per-module `ApacheLicenceHeaderTest` classes are removed.**
- **`ApacheLicenseHeaderTestCase` is deprecated for removal.** It is public
API in wicket-util's main code, as is the `ApacheLicenceHeaderTest` next to it,
so both stay with `@Deprecated(since = "10.12.0, 11.0.0", forRemoval = true)`.
- If 10.12.0 or 11.0.0 is released from the RC currently under vote,
`since` needs to move to the next version.
- **The XML-prolog check goes too.** The tests also checked that HTML and
XML files start with an XML prolog; RAT does not replace that.
## Migration
Applications that extend `ApacheLicenseHeaderTestCase` keep working and get
a deprecation warning. There is no mechanical migration, so there is no
OpenRewrite recipe.
Proposed migration guide text:
> `ApacheLicenseHeaderTestCase` is deprecated for removal. Wicket checks its
own license headers with Apache RAT; use `apache-rat-plugin` in your build
instead.
## Verification
- `mvn clean verify -Pjs-test` passes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]