This is an automated email from the ASF dual-hosted git repository.

dashorst pushed a commit to branch fix-release-script-generated-files
in repository https://gitbox.apache.org/repos/asf/wicket.git

commit 2261fabe551e4bb684a2c8ef514ea7d6923c0423
Author: Martijn Dashorst <[email protected]>
AuthorDate: Sun Nov 1 13:38:53 2026 +0100

    Keep the quotes in the commands that promote-$version.sh prints
    
    release.sh reads the templates of the promote and revert scripts with
    read, which without -r treats a backslash as an escape and drops it. In
    the closing message of promote-$version.sh the escaped quotes around
    "Start next development version" lost their backslash, ended the echo
    string early, and the script printed the suggested commit command as
    
      git commit -m Start next development version
    
    The svn rm line printed its quotes only because it was escaped twice to
    make up for this.
    
    Both templates are read with read -r now, so a backslash in a template
    reaches the generated script unchanged, and the svn rm line is escaped
    once like the commit line. The printed commands are copyable again;
    the revert script contains no backslashes and comes out the same.
    
    Generated-by: Claude Code (Claude Opus 5.5)
---
 release.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/release.sh b/release.sh
index 231a48565a..8ca1499cd3 100755
--- a/release.sh
+++ b/release.sh
@@ -49,7 +49,7 @@ function getJdkToolchain {
 
 function generate_promotion_script {
     echo "Generating release promotion script 'promote-$version.sh'"
-read -d '' script <<- EOF
+read -r -d '' script <<- EOF
 #!/bin/bash
 set -e
 echo "Promoting release $version
@@ -88,7 +88,7 @@ Check the new versions and commit and push them to origin:
 
 Remove the previous version of Wicket using this command:
 
-  svn rm https://dist.apache.org/repos/dist/release/wicket/$previous_version 
-m \\\"Remove previous version from mirrors\\\"
+  svn rm https://dist.apache.org/repos/dist/release/wicket/$previous_version 
-m \"Remove previous version from mirrors\"
 
 "  
 EOF
@@ -100,7 +100,7 @@ echo "$script" > promote-$version.sh
 
 function generate_rollback_script {
        echo "Generating release rollback script 'revert-$version.sh'"
-read -d '' script <<- EOF
+read -r -d '' script <<- EOF
 #!/bin/bash
 set -e
 echo -n "Reverting release $version

Reply via email to