zabetak commented on code in PR #352: URL: https://github.com/apache/incubator-xtable/pull/352#discussion_r1508647679
########## website/README.md: ########## @@ -1,6 +1,6 @@ -# OneTable Website Source Code +# XTable Website Source Code -This repo hosts the source code of [OneTable](https://onetable.dev) +This repo hosts the source code of [XTable](https://onetable.dev) Review Comment: Shouldn't the link be updated to point to the GitHub Repo? ########## website/static/images/xtable-svg.svg: ########## @@ -0,0 +1,70 @@ +<svg width="554" height="150" viewBox="0 0 554 150" fill="none" xmlns="http://www.w3.org/2000/svg";> Review Comment: How was the logo produced? If it was created from scratch the we are fine. If it was imported/found from somewhere else then it may not be OK to use it. ########## README.md: ########## @@ -1,15 +1,15 @@ -# OneTable +# XTable Review Comment: According to the [branding guide](https://incubator.apache.org/guides/branding.html) and [ASF branding policy](https://www.apache.org/foundation/marks/pmcs) we must refer to the project as Apache XTable not simply as XTable. The first most prominent reference to the project in every page/doc/etc must be Apache XTable for the rest it may be fine to leave it as XTable. ########## website/static/images/xtable-hero.svg: ########## @@ -0,0 +1,147 @@ +<svg width="736" height="710" viewBox="0 0 736 710" fill="none" xmlns="http://www.w3.org/2000/svg";> Review Comment: Please include the [ASF source header](https://www.apache.org/legal/src-headers.html#headers) in all .svg files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
