danielhumanmod commented on code in PR #518:
URL: https://github.com/apache/incubator-xtable/pull/518#discussion_r1726211254
##########
xtable-core/src/test/java/org/apache/xtable/iceberg/TestIcebergDataHelper.java:
##########
@@ -99,7 +99,9 @@ public class TestIcebergDataHelper {
NestedField.optional(
28, "timestamp_micros_nullable_field",
Types.TimestampType.withZone()),
NestedField.optional(
- 30, "timestamp_local_micros_nullable_field",
Types.TimestampType.withoutZone()));
+ 30, "timestamp_local_micros_nullable_field",
Types.TimestampType.withoutZone()),
+ NestedField.optional(33, "uuid_field", Types.UUIDType.get())
Review Comment:
> Does Iceberg to Delta work as expected? If only Hudi is broken, we can
list that as a limitation and make a test case for Iceberg to Delta for now.
The conversion from Iceberg to Delta success, but there is a diff in the
result:
- Iceberg: "uuid_field":"8135e4c4-ea58-4ace-a819-4f835cb2b721"
- Delta: "uuid_field":"gTXkxOpYSs6oGU+DXLK3IQ=="
In fact these two data are the same(`8135e4c4-ea58-4ace-a819-4f835cb2b721`
equals `8135e4c4-ea58-4ace-a819-4f835cb2b721`), but assertion fails in this
diff because the data format in two table is different - data format in the two
tables is different—Iceberg supports UUIDs directly, while Delta represents
them as binary.
Should we consider adding special comparison logic in
`checkDatasetEquivalence` for these specific cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
