danielhumanmod commented on code in PR #518:
URL: https://github.com/apache/incubator-xtable/pull/518#discussion_r1739925466
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaSchemaExtractor.java:
##########
@@ -172,7 +186,11 @@ private InternalSchema toInternalSchema(
type = InternalType.DOUBLE;
break;
case "binary":
- type = InternalType.BYTES;
+ if ("uuid".equals(originalMetadata.getString("xtableLogicalType"))) {
Review Comment:
> the `getString` is failing when I run locally. I think there needs to be a
`contains` check first or else you get this `java.util.NoSuchElementException:
key not found: xtableLogicalType`
Sorry, I have committed this changes locally before but forget to push,
already fixed in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
