emilie-wang commented on code in PR #526:
URL: https://github.com/apache/incubator-xtable/pull/526#discussion_r1737480094
##########
xtable-core/src/test/java/org/apache/xtable/delta/TestDeltaValueConverter.java:
##########
@@ -82,6 +82,15 @@ void parseWrongDateTime() throws ParseException {
assertThrows(ParseException.class, () ->
strictDateFormat.parse(wrongDateTime));
}
+ @ParameterizedTest
+ @MethodSource("nonNumericValuesForColStats")
+ public void formattedDifferentNonNumericValuesFromDeltaColumnStat(
+ Object fieldValue, InternalSchema fieldSchema, Object
expectedDeltaValue) {
+ Object internalRepresentation =
+ DeltaValueConverter.convertFromDeltaColumnStatValue(fieldValue,
fieldSchema);
+ assertEquals(internalRepresentation, expectedDeltaValue);
Review Comment:
Good question, we suppose the internal representation always has correct
field value which corresponding to field schema, and existing tests have
already covered the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
