the-other-tim-brown commented on code in PR #526:
URL: https://github.com/apache/incubator-xtable/pull/526#discussion_r1750331694
##########
xtable-core/src/test/java/org/apache/xtable/delta/TestDeltaValueConverter.java:
##########
@@ -82,6 +82,15 @@ void parseWrongDateTime() throws ParseException {
assertThrows(ParseException.class, () ->
strictDateFormat.parse(wrongDateTime));
}
+ @ParameterizedTest
+ @MethodSource("nonNumericValuesForColStats")
+ public void formattedDifferentNonNumericValuesFromDeltaColumnStat(
Review Comment:
We have a linter that flags this stuff which is why I selfishly flagged this
for my own internal cherry-pick later :) I am fine with just doing this on new
tests for now. Maybe later we can integrate a linter into the the ASF toolkit
as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
