danielhumanmod commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1868711691
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaConversionTarget.java:
##########
@@ -215,13 +224,64 @@ public String getTableFormat() {
return TableFormat.DELTA;
}
+ @Override
+ public Optional<String> getTargetCommitIdentifier(String sourceIdentifier) {
Review Comment:
> If there is no commit Identifier in the latest commit, should this just
return an empty Optional?
Yes, if we can not find the corresponding target commit, we will return an
empty Optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
