the-other-tim-brown commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1878309851
##########
xtable-api/src/main/java/org/apache/xtable/model/metadata/TableSyncMetadata.java:
##########
@@ -51,6 +51,8 @@ public class TableSyncMetadata {
/** Property name for the XTABLE metadata in the table metadata/properties */
public static final String XTABLE_METADATA = "XTABLE_METADATA";
+ public static final String XTABLE_SOURCE_METADATA = "XTABLE_SOURCE_METADATA";
Review Comment:
I am wondering if all of the information should actually be stored at the
commit level instead of table level. In the Hudi target, the information is
already stored at the commit level since that was the intention and the format
I knew best. The others, it seems like I did not add the metadata to the
correct location.
The source format should be allowed to change over time for flexibility so I
think it is best to keep that at the commit level as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
