vamsikarnika commented on code in PR #639:
URL: https://github.com/apache/incubator-xtable/pull/639#discussion_r1942711897
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaSchemaExtractor.java:
##########
@@ -59,104 +55,12 @@
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public class DeltaSchemaExtractor {
private static final String DELTA_COLUMN_MAPPING_ID =
"delta.columnMapping.id";
- private static final String COMMENT = "comment";
private static final DeltaSchemaExtractor INSTANCE = new
DeltaSchemaExtractor();
public static DeltaSchemaExtractor getInstance() {
return INSTANCE;
}
- public StructType fromInternalSchema(InternalSchema internalSchema) {
- StructField[] fields =
- internalSchema.getFields().stream()
- .map(
- field ->
- new StructField(
- field.getName(),
- convertFieldType(field),
- field.getSchema().isNullable(),
- getMetaData(field.getSchema())))
- .toArray(StructField[]::new);
- return new StructType(fields);
- }
-
- private DataType convertFieldType(InternalField field) {
- switch (field.getSchema().getDataType()) {
- case ENUM:
- case STRING:
- return DataTypes.StringType;
- case INT:
- return DataTypes.IntegerType;
- case LONG:
- case TIMESTAMP_NTZ:
- return DataTypes.LongType;
- case BYTES:
- case FIXED:
- case UUID:
- return DataTypes.BinaryType;
- case BOOLEAN:
- return DataTypes.BooleanType;
- case FLOAT:
- return DataTypes.FloatType;
- case DATE:
- return DataTypes.DateType;
- case TIMESTAMP:
- return DataTypes.TimestampType;
- case DOUBLE:
- return DataTypes.DoubleType;
- case DECIMAL:
- int precision =
- (int)
field.getSchema().getMetadata().get(InternalSchema.MetadataKey.DECIMAL_PRECISION);
- int scale =
- (int)
field.getSchema().getMetadata().get(InternalSchema.MetadataKey.DECIMAL_SCALE);
- return DataTypes.createDecimalType(precision, scale);
- case RECORD:
- return fromInternalSchema(field.getSchema());
- case MAP:
- InternalField key =
- field.getSchema().getFields().stream()
- .filter(
- mapField ->
-
InternalField.Constants.MAP_KEY_FIELD_NAME.equals(mapField.getName()))
- .findFirst()
- .orElseThrow(() -> new SchemaExtractorException("Invalid map
schema"));
- InternalField value =
- field.getSchema().getFields().stream()
- .filter(
- mapField ->
-
InternalField.Constants.MAP_VALUE_FIELD_NAME.equals(mapField.getName()))
- .findFirst()
- .orElseThrow(() -> new SchemaExtractorException("Invalid map
schema"));
- return DataTypes.createMapType(
- convertFieldType(key), convertFieldType(value),
value.getSchema().isNullable());
- case LIST:
- InternalField element =
- field.getSchema().getFields().stream()
- .filter(
- arrayField ->
-
InternalField.Constants.ARRAY_ELEMENT_FIELD_NAME.equals(
- arrayField.getName()))
- .findFirst()
- .orElseThrow(() -> new SchemaExtractorException("Invalid array
schema"));
- return DataTypes.createArrayType(
- convertFieldType(element), element.getSchema().isNullable());
- default:
- throw new NotSupportedException("Unsupported type: " +
field.getSchema().getDataType());
- }
- }
-
- private Metadata getMetaData(InternalSchema schema) {
- InternalType type = schema.getDataType();
- MetadataBuilder metadataBuilder = new MetadataBuilder();
- if (type == InternalType.UUID) {
- metadataBuilder.putString(InternalSchema.XTABLE_LOGICAL_TYPE, "uuid");
- }
- if (schema.getComment() != null) {
- metadataBuilder.putString(COMMENT, schema.getComment());
- }
- return metadataBuilder.build();
- }
-
Review Comment:
This method is moved to SparkSchemaExtractor class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
