vamsikarnika commented on code in PR #639: URL: https://github.com/apache/incubator-xtable/pull/639#discussion_r1942727506
########## xtable-hive-metastore/src/test/java/org/apache/xtable/hms/HMSCatalogSyncTestBase.java: ########## @@ -22,21 +22,26 @@ import java.util.HashMap; import java.util.Map; +import org.apache.avro.Schema; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.hive.metastore.IMetaStoreClient; import org.apache.hadoop.hive.metastore.api.Database; import org.apache.hadoop.hive.metastore.api.StorageDescriptor; import org.apache.hadoop.hive.metastore.api.Table; import org.mockito.Mock; +import org.apache.xtable.avro.AvroSchemaConverter; import org.apache.xtable.conversion.ExternalCatalogConfig; import org.apache.xtable.model.InternalTable; import org.apache.xtable.model.catalog.ThreePartHierarchicalTableIdentifier; +import org.apache.xtable.model.schema.InternalField; +import org.apache.xtable.model.schema.InternalPartitionField; import org.apache.xtable.model.schema.InternalSchema; +import org.apache.xtable.model.schema.InternalType; import org.apache.xtable.model.storage.CatalogType; import org.apache.xtable.model.storage.TableFormat; -public class HMSCatalogSyncClientTestBase { +public class HMSCatalogSyncTestBase { Review Comment: renamed the class to HMSCatalogSyncTestBase, since this test base is not just used by Catalog Sync tests, also used by CatalogPartitionSyncOperations tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org