vamsikarnika commented on code in PR #639:
URL: https://github.com/apache/incubator-xtable/pull/639#discussion_r1942740419
##########
xtable-utilities/src/main/java/org/apache/xtable/utilities/RunCatalogSync.java:
##########
@@ -233,10 +236,21 @@ static SourceTable getSourceTable(
.get()
.getSourceTable(
getCatalogTableIdentifier(sourceTableIdentifier.getTableIdentifier()));
+ Map<String, String> tableProperties =
sourceTableIdentifier.getTableProperties();
+ if (tableProperties != null && !tableProperties.isEmpty()) {
+ sourceTable.getAdditionalProperties().putAll(tableProperties);
+ }
}
return sourceTable;
}
+ static String getSourceTableLocation(String targetTableFormat, SourceTable
sourceTable) {
+ return sourceTable.getFormatName().equals(TableFormat.ICEBERG)
+ && targetTableFormat.equals(TableFormat.HUDI)
+ ? sourceTable.getDataPath()
+ : sourceTable.getBasePath();
Review Comment:
When source is ICEBERG and target is HUDI, we need to set the basepath of
the target table to match the iceberg's datapath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
