danielhumanmod commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1950262732
##########
xtable-api/src/main/java/org/apache/xtable/spi/sync/ConversionTarget.java:
##########
@@ -90,4 +90,14 @@ public interface ConversionTarget {
/** Initializes the client with provided configuration */
void init(TargetTable targetTable, Configuration configuration);
+
+ /**
+ * Retrieves the commit identifier from the target table that corresponds to
a given source table
+ * commit identifier
Review Comment:
> Will these identifier's always be the same? if so, is it simpler to make
this a boolean method?
Yes the source identifier stored in the target table remains unchanged.
However, this API is designed to retrieve the corresponding target COMMIT based
on an input source identifier (It would be the rollback source COMMIT in this
feature). This allows us to initiate a rollback to the retrieved target COMMIT
on the target table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
