brishi19791 commented on code in PR #663:
URL: https://github.com/apache/incubator-xtable/pull/663#discussion_r1988005008
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java:
##########
@@ -247,7 +247,7 @@ public boolean isIncrementalSyncSafeFrom(Instant instant) {
long timeInMillis = instant.toEpochMilli();
Table iceTable = getSourceTable();
boolean doesInstantOfAgeExists = false;
- Long targetSnapshotId = null;
Review Comment:
Thanks for the PR @the-other-tim-brown. As @ashvina mentioned this PR does
not address the issue which I reported. Raised this PR #665 to address the
issue #660. Please share your thoughts and if it looks good let me know how to
include this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
