the-other-tim-brown commented on code in PR #663:
URL: https://github.com/apache/incubator-xtable/pull/663#discussion_r1988009926
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java:
##########
@@ -247,7 +247,7 @@ public boolean isIncrementalSyncSafeFrom(Instant instant) {
long timeInMillis = instant.toEpochMilli();
Table iceTable = getSourceTable();
boolean doesInstantOfAgeExists = false;
- Long targetSnapshotId = null;
Review Comment:
@brishi19791 can you add the test updates from this branch in your PR? if
so, we can close this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
